Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add upgrade document #1777

Merged
merged 4 commits into from
Aug 25, 2022
Merged

add upgrade document #1777

merged 4 commits into from
Aug 25, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Aug 18, 2022 •
edited
Loading

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi
📝 add upgrade document
deff2d8 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi requested review from kevindiu, a team and datelier and removed request for a team August 18, 2022 01:42
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions[bot]
github-actions bot reviewed Aug 18, 2022
View reviewed changes
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
@vankichi
📝 fix
dba2e2c 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 18, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8c355f
Status: ✅  Deploy successful!
Preview URL: https://d0c71d4c.vald.pages.dev
Branch Preview URL: https://documentation-docs-add-upgra.vald.pages.dev

View logs

datelier
datelier previously approved these changes Aug 18, 2022
View reviewed changes
kevindiu
kevindiu reviewed Aug 22, 2022
View reviewed changes
docs/user-guides/upgrade-cluster.md Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
docs/user-guides/upgrade-cluster.md Outdated Show resolved Hide resolved
vankichi and others added 2 commits August 23, 2022 10:32
@vankichi @kevindiu
Update docs/user-guides/upgrade-cluster.md
57ca075 
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi
📝 apply feedback
b8c355f 
Signed-off-by: vankichi <kyukawa315@gmail.com>
github-actions[bot]
github-actions bot reviewed Aug 23, 2022
View reviewed changes
docs/user-guides/upgrade-cluster.md

```bash
helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
# e.g., helm upgrade vald vald/vald --values valeus.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

docs/user-guides/upgrade-cluster.md

```bash
helm upgrade <NAME> vald/vald --values <YOUR VALUES FILE PATH>
# e.g., helm upgrade vald vald/vald --values valeus.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: vald
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC

docs/user-guides/upgrade-cluster.md

```yaml
...
spec:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Spec
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

docs/user-guides/upgrade-cluster.md
spec:
defaults:
...
image:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Image
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING

@vankichi vankichi requested a review from kpango August 25, 2022 04:28
kpango
kpango approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 5262c62 into main Aug 25, 2022
@vankichi vankichi deleted the documentation/docs/add-upgrade-document branch August 25, 2022 05:12
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@kevindiu kevindiu kevindiu approved these changes

@kpango kpango kpango approved these changes

@datelier datelier datelier approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vankichi @vdaas-ci @kevindiu @kpango @datelier